Track service name source#10607
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~c0e1c11a92, baseline=1.60.0-SNAPSHOT~af8b84438c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063569
Total [baseline] (8.742 s) : 0, 8742337
Agent [candidate] (1.066 s) : 0, 1065978
Total [candidate] (8.753 s) : 0, 8753159
section iast
Agent [baseline] (1.228 s) : 0, 1228078
Total [baseline] (9.389 s) : 0, 9389411
Agent [candidate] (1.229 s) : 0, 1228677
Total [candidate] (9.387 s) : 0, 9386927
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~c0e1c11a92, baseline=1.60.0-SNAPSHOT~af8b84438c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (626.134 ms) : 0, 626134
BytebuddyAgent [candidate] (629.476 ms) : 0, 629476
AgentMeter [baseline] (29.007 ms) : 0, 29007
AgentMeter [candidate] (28.957 ms) : 0, 28957
GlobalTracer [baseline] (257.348 ms) : 0, 257348
GlobalTracer [candidate] (256.927 ms) : 0, 256927
AppSec [baseline] (33.071 ms) : 0, 33071
AppSec [candidate] (32.89 ms) : 0, 32890
Debugger [baseline] (64.083 ms) : 0, 64083
Debugger [candidate] (65.586 ms) : 0, 65586
Remote Config [baseline] (619.275 µs) : 0, 619
Remote Config [candidate] (611.777 µs) : 0, 612
Telemetry [baseline] (10.584 ms) : 0, 10584
Telemetry [candidate] (9.03 ms) : 0, 9030
Flare Poller [baseline] (5.406 ms) : 0, 5406
Flare Poller [candidate] (5.213 ms) : 0, 5213
section iast
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (793.416 ms) : 0, 793416
BytebuddyAgent [candidate] (794.184 ms) : 0, 794184
AgentMeter [baseline] (11.205 ms) : 0, 11205
AgentMeter [candidate] (11.291 ms) : 0, 11291
GlobalTracer [baseline] (246.916 ms) : 0, 246916
GlobalTracer [candidate] (247.123 ms) : 0, 247123
IAST [baseline] (27.037 ms) : 0, 27037
IAST [candidate] (26.989 ms) : 0, 26989
AppSec [baseline] (32.297 ms) : 0, 32297
AppSec [candidate] (34.718 ms) : 0, 34718
Debugger [baseline] (67.664 ms) : 0, 67664
Debugger [candidate] (64.57 ms) : 0, 64570
Remote Config [baseline] (541.875 µs) : 0, 542
Remote Config [candidate] (542.942 µs) : 0, 543
Telemetry [baseline] (8.537 ms) : 0, 8537
Telemetry [candidate] (8.627 ms) : 0, 8627
Flare Poller [baseline] (3.443 ms) : 0, 3443
Flare Poller [candidate] (3.501 ms) : 0, 3501
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~c0e1c11a92, baseline=1.60.0-SNAPSHOT~af8b84438c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074836
Total [baseline] (10.945 s) : 0, 10944946
Agent [candidate] (1.065 s) : 0, 1065382
Total [candidate] (10.979 s) : 0, 10979177
section appsec
Agent [baseline] (1.236 s) : 0, 1236054
Total [baseline] (11.0 s) : 0, 11000190
Agent [candidate] (1.248 s) : 0, 1248346
Total [candidate] (11.112 s) : 0, 11111690
section iast
Agent [baseline] (1.235 s) : 0, 1234809
Total [baseline] (11.162 s) : 0, 11161935
Agent [candidate] (1.23 s) : 0, 1230130
Total [candidate] (11.205 s) : 0, 11204930
section profiling
Agent [baseline] (1.189 s) : 0, 1188529
Total [baseline] (10.92 s) : 0, 10919801
Agent [candidate] (1.191 s) : 0, 1190859
Total [candidate] (10.973 s) : 0, 10972945
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~c0e1c11a92, baseline=1.60.0-SNAPSHOT~af8b84438c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (633.786 ms) : 0, 633786
BytebuddyAgent [candidate] (628.561 ms) : 0, 628561
AgentMeter [baseline] (29.523 ms) : 0, 29523
AgentMeter [candidate] (29.008 ms) : 0, 29008
GlobalTracer [baseline] (259.928 ms) : 0, 259928
GlobalTracer [candidate] (257.92 ms) : 0, 257920
AppSec [baseline] (33.234 ms) : 0, 33234
AppSec [candidate] (33.08 ms) : 0, 33080
Debugger [baseline] (64.736 ms) : 0, 64736
Debugger [candidate] (63.598 ms) : 0, 63598
Remote Config [baseline] (637.124 µs) : 0, 637
Remote Config [candidate] (621.423 µs) : 0, 621
Telemetry [baseline] (10.879 ms) : 0, 10879
Telemetry [candidate] (9.148 ms) : 0, 9148
Flare Poller [baseline] (4.684 ms) : 0, 4684
Flare Poller [candidate] (6.231 ms) : 0, 6231
section appsec
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (656.243 ms) : 0, 656243
BytebuddyAgent [candidate] (666.665 ms) : 0, 666665
AgentMeter [baseline] (11.961 ms) : 0, 11961
AgentMeter [candidate] (12.027 ms) : 0, 12027
GlobalTracer [baseline] (257.681 ms) : 0, 257681
GlobalTracer [candidate] (258.385 ms) : 0, 258385
AppSec [baseline] (167.192 ms) : 0, 167192
AppSec [candidate] (167.758 ms) : 0, 167758
Debugger [baseline] (66.855 ms) : 0, 66855
Debugger [candidate] (66.976 ms) : 0, 66976
Remote Config [baseline] (648.102 µs) : 0, 648
Remote Config [candidate] (652.651 µs) : 0, 653
Telemetry [baseline] (9.412 ms) : 0, 9412
Telemetry [candidate] (9.479 ms) : 0, 9479
Flare Poller [baseline] (3.674 ms) : 0, 3674
Flare Poller [candidate] (3.722 ms) : 0, 3722
IAST [baseline] (25.245 ms) : 0, 25245
IAST [candidate] (25.342 ms) : 0, 25342
section iast
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (798.264 ms) : 0, 798264
BytebuddyAgent [candidate] (794.036 ms) : 0, 794036
AgentMeter [baseline] (11.325 ms) : 0, 11325
AgentMeter [candidate] (11.307 ms) : 0, 11307
GlobalTracer [baseline] (247.854 ms) : 0, 247854
GlobalTracer [candidate] (247.672 ms) : 0, 247672
AppSec [baseline] (34.816 ms) : 0, 34816
AppSec [candidate] (32.821 ms) : 0, 32821
Debugger [baseline] (65.681 ms) : 0, 65681
Debugger [candidate] (67.468 ms) : 0, 67468
Remote Config [baseline] (548.572 µs) : 0, 549
Remote Config [candidate] (534.697 µs) : 0, 535
Telemetry [baseline] (8.672 ms) : 0, 8672
Telemetry [candidate] (8.574 ms) : 0, 8574
Flare Poller [baseline] (3.435 ms) : 0, 3435
Flare Poller [candidate] (3.485 ms) : 0, 3485
IAST [baseline] (27.082 ms) : 0, 27082
IAST [candidate] (27.058 ms) : 0, 27058
section profiling
ProfilingAgent [baseline] (98.507 ms) : 0, 98507
ProfilingAgent [candidate] (99.023 ms) : 0, 99023
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (681.33 ms) : 0, 681330
BytebuddyAgent [candidate] (682.314 ms) : 0, 682314
AgentMeter [baseline] (8.513 ms) : 0, 8513
AgentMeter [candidate] (8.553 ms) : 0, 8553
GlobalTracer [baseline] (215.696 ms) : 0, 215696
GlobalTracer [candidate] (216.157 ms) : 0, 216157
AppSec [baseline] (32.503 ms) : 0, 32503
AppSec [candidate] (32.917 ms) : 0, 32917
Debugger [baseline] (66.865 ms) : 0, 66865
Debugger [candidate] (66.992 ms) : 0, 66992
Remote Config [baseline] (621.58 µs) : 0, 622
Remote Config [candidate] (619.336 µs) : 0, 619
Telemetry [baseline] (9.026 ms) : 0, 9026
Telemetry [candidate] (8.831 ms) : 0, 8831
Flare Poller [baseline] (3.745 ms) : 0, 3745
Flare Poller [candidate] (3.731 ms) : 0, 3731
Profiling [baseline] (99.085 ms) : 0, 99085
Profiling [candidate] (99.591 ms) : 0, 99591
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~c0e1c11a92, baseline=1.60.0-SNAPSHOT~af8b84438c
dateFormat X
axisFormat %s
section baseline
no_agent (19.306 ms) : 19107, 19505
. : milestone, 19306,
appsec (18.731 ms) : 18541, 18922
. : milestone, 18731,
code_origins (17.782 ms) : 17607, 17957
. : milestone, 17782,
iast (17.721 ms) : 17546, 17895
. : milestone, 17721,
profiling (18.612 ms) : 18426, 18798
. : milestone, 18612,
tracing (17.788 ms) : 17611, 17965
. : milestone, 17788,
section candidate
no_agent (17.94 ms) : 17758, 18122
. : milestone, 17940,
appsec (19.275 ms) : 19083, 19468
. : milestone, 19275,
code_origins (18.324 ms) : 18137, 18510
. : milestone, 18324,
iast (17.714 ms) : 17538, 17890
. : milestone, 17714,
profiling (18.898 ms) : 18710, 19086
. : milestone, 18898,
tracing (17.914 ms) : 17736, 18093
. : milestone, 17914,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~c0e1c11a92, baseline=1.60.0-SNAPSHOT~af8b84438c
dateFormat X
axisFormat %s
section baseline
no_agent (1.181 ms) : 1170, 1192
. : milestone, 1181,
iast (3.144 ms) : 3102, 3186
. : milestone, 3144,
iast_FULL (5.797 ms) : 5739, 5856
. : milestone, 5797,
iast_GLOBAL (3.597 ms) : 3540, 3655
. : milestone, 3597,
profiling (2.059 ms) : 2040, 2077
. : milestone, 2059,
tracing (1.793 ms) : 1778, 1808
. : milestone, 1793,
section candidate
no_agent (1.174 ms) : 1162, 1185
. : milestone, 1174,
iast (3.292 ms) : 3246, 3337
. : milestone, 3292,
iast_FULL (5.626 ms) : 5570, 5683
. : milestone, 5626,
iast_GLOBAL (3.466 ms) : 3408, 3523
. : milestone, 3466,
profiling (2.049 ms) : 2031, 2067
. : milestone, 2049,
tracing (1.796 ms) : 1779, 1814
. : milestone, 1796,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~c0e1c11a92, baseline=1.60.0-SNAPSHOT~af8b84438c
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1495
. : milestone, 1483,
appsec (2.602 ms) : 2544, 2661
. : milestone, 2602,
iast (2.27 ms) : 2201, 2340
. : milestone, 2270,
iast_GLOBAL (2.308 ms) : 2238, 2378
. : milestone, 2308,
profiling (2.117 ms) : 2060, 2173
. : milestone, 2117,
tracing (2.083 ms) : 2029, 2137
. : milestone, 2083,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.532 ms) : 2477, 2587
. : milestone, 2532,
iast (2.262 ms) : 2192, 2331
. : milestone, 2262,
iast_GLOBAL (2.33 ms) : 2259, 2401
. : milestone, 2330,
profiling (2.107 ms) : 2052, 2163
. : milestone, 2107,
tracing (2.079 ms) : 2025, 2133
. : milestone, 2079,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~c0e1c11a92, baseline=1.60.0-SNAPSHOT~af8b84438c
dateFormat X
axisFormat %s
section baseline
no_agent (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
appsec (14.903 s) : 14903000, 14903000
. : milestone, 14903000,
iast (17.746 s) : 17746000, 17746000
. : milestone, 17746000,
iast_GLOBAL (17.723 s) : 17723000, 17723000
. : milestone, 17723000,
profiling (14.719 s) : 14719000, 14719000
. : milestone, 14719000,
tracing (14.663 s) : 14663000, 14663000
. : milestone, 14663000,
section candidate
no_agent (14.944 s) : 14944000, 14944000
. : milestone, 14944000,
appsec (14.811 s) : 14811000, 14811000
. : milestone, 14811000,
iast (17.99 s) : 17990000, 17990000
. : milestone, 17990000,
iast_GLOBAL (17.694 s) : 17694000, 17694000
. : milestone, 17694000,
profiling (14.744 s) : 14744000, 14744000
. : milestone, 14744000,
tracing (14.576 s) : 14576000, 14576000
. : milestone, 14576000,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.
See unchanged results
|
7a4d869 to
32dba74
Compare
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
f4aa3fe to
a7f8b76
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
is the client stats part being done in a different PR? https://github.com/DataDog/datadog-agent/pull/45982/changes |
yep I will stack another PR on top |
|
could you send a few test data on datadog with this PR to double check from UI |
...-java-sdk-1.11/src/main/java/datadog/trace/instrumentation/aws/v0/AwsSdkClientDecorator.java
Show resolved
Hide resolved
d070b9a to
8bfae7a
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
This change introduces service name source tracking, allowing us to record which integration or feature overrides the service name on a span.
To support this, a new
setServiceNameAPI has been added toAgentSpan. In addition to the service name, this method also accepts aCharSequencerepresenting the source of the override.For durability, the old signature has been deprecated on AgentSpan. Also, a forbiddenApi check has been added to all the integration to discourage the usage of the previous method that is missing the source of override.
When a source is set on a span, it is automatically propagated to its local children, since they inherit the same service name.
Manual tracing is currently out of scope. However, in the future we may extend this mechanism to track manual overrides as a
"manual"source.If a source is present on a span, an eager post-processor records it under the
_dd.svc_srctag.Please note that trace statistics will also need to incorporate this source information. That update will be handled in a separate PR.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.